New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SpreadsheetView code to JavaFX 17 #1463
Open
Groostav
wants to merge
38
commits into
controlsfx:master
Choose a base branch
from
Groostav:sam-update-code-to-jfx17
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
f7eaf8f
Release v8.40.18
abhinayagarwal dc02f72
Upgrade version to 8.40.19-SNAPSHOT
cce2063
Remove VirtualFlow reflection methods in gridViewSkin
Maxoudela d292e6e
Update license, remove unused imports and jvm args
abhinayagarwal 5f49d3f
Merge branch 'controlsfx:jfx-13' into jfx-13
Maxoudela e9e568c
Merge branch 'controlsfx:jfx-13' into jfx-13
Maxoudela 7020100
Merge branch 'controlsfx:jfx-13' into jfx-13
Maxoudela ae18992
- Update code to be similar to OpenJFX 17 one.
Maxoudela 246d898
Use WeakEventHandler for ContextMenu onShowing and onAction to avoid …
Maxoudela 2595a4c
Rename scrollTo to scrollToTop in order to see rows that are scrolled…
Maxoudela 8761dee
Re-activate resizing of several columns at once.
Maxoudela a6885c6
Merge branch 'master' of https://github.com/controlsfx/controlsfx int…
Maxoudela 8eaf545
Key pressed to trigger edition is considered for first time edition.
Maxoudela c94d7b3
Apply CSS to cell before loading style in browser
Maxoudela 949ad65
Refactor HorizontalPicker to avoid infinite loop by trying to reuse p…
Maxoudela c10e53f
Refactor VerticalHeader to avoid infinite loop by trying to reuse pic…
Maxoudela 6faf618
Remove useless requestLayout methods
Maxoudela dc5d79f
Fix autofit for columns to use the GridViewSkin algorithm
Maxoudela 0c1fce6
Update SpreadsheetView selection model in order to only scroll to sel…
Maxoudela 991b6b2
Remove useless mouse click handler since key released is doing the tr…
Maxoudela 94cd06b
Use a ConcurrentHashMap instead of a normal HashMap to avoid concurre…
Maxoudela 51b7eef
Force the css to be applied before computing the height of a cell tha…
Maxoudela f78a63a
Register arrow movement instead of all keys for more precision for sc…
Maxoudela 77655a6
Remove class selectors as they are not working anymore (the reason is…
Maxoudela ca52840
Using visibility instead of children size for retrieving the top row
Maxoudela 7278780
Reduce the size of scrollBars inside Cell's TextArea with big fonts
Maxoudela ac77e88
Merge pull request #3 from controlsfx/jfx-13
Maxoudela 179d723
Avoid NPE that can happen somehow on extreme case in GridRowSkin.
Maxoudela 09eb1e7
Authorize to add a filter on a spanned cell (in column) (only one fi…
Maxoudela 217189a
Refresh the TableView when resizing rows to update the scrollBars acc…
Maxoudela ae3d83c
Preventing tab and enter to be inserted in textArea editor when press…
Maxoudela 06e3e43
Remove unnecessary left padding for JDK 17.
Maxoudela 07b5638
Fix code for activate in GridVieBehavior: activate is allowed if no e…
Maxoudela a5e7dbd
Preventing memory leak in GridRow by using a weakMapListener.
Maxoudela be95200
Preventing constant layout in VirtualFlow when zooming.
Maxoudela 25e97fa
Merge branch 'controlsfx:master' into sam-update-code-to-jfx17
Maxoudela dbc36be
Merge branch 'master' into sam-update-code-to-jfx17
Groostav 8c0ac3c
Update gradle deps to jfx17
Groostav File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
295 changes: 139 additions & 156 deletions
295
controlsfx/src/main/java/impl/org/controlsfx/spreadsheet/GridRowSkin.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I this PR is compatible with JDK 13/11, this code needs to be checked because I don't know if that behavior was specific to JDK 17 or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I compiled the library with java 17 targeting java 11, and than ran it under java 11. I opened the speadsheet view, edited some cells, used the enter and tab keys.
Given:
this method is called through the KeyMapping's specified in TableViewBehaviorBase
two test paths:
f2