Allow the developer to specify that the ListSelectionView source and target lists should be sorted. #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi torrlane, Welcome to ControlsFX and thank you for taking time to contribute to this project. We do not recognise you as a contributor. Can you please sign ControlsFX Individual Contributor Agreement: https://cla.controlsfx.org ? |
torrlane
changed the title
| @@ -474,6 +475,22 @@ protected final void setEventHandler(Consumer<ActionEvent> eventHandler) { | |||
| super.setEventHandler(eventHandler); | |||
| } | |||
| } | |||
|
|
|||
| private Comparator<T> comparator; | |||
There was a problem hiding this comment.
Please convert this into ObjectProperty<Comparator>. Have a look into other properties in the class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user moves an item from the source list to the target list, or vice versa. The item always appears at the end of the destination list. This can sometimes be undesirable behaviour e.g. if the destination list is very long, then it might not be obvious that the item has arrived.
I think that it would be useful to allow the developer to set a sort order on the lists so that it should be easier for the user to find things and more obvious when they have added / removed entries.