Fixed bug where high thumb & rangeBar missing #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s visibility change
|
Can you open an issue in the tracker with a description of the bug so that this PR can be linked to it? |
|
PR for issue #1499 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR fix a bug where the high thumb and range bar are missing in RangeSlider when you change the tick marks / labels visibility
I think the problem culprit is here:
controlsfx/controlsfx/src/main/java/impl/org/controlsfx/skin/RangeSliderSkin.java
Line 314 in b0cec18
The method documentation says: "After this method, we must be sure to add the high Thumb and the rangeBar." but I don't see any code line which does that.
It worked fine with 8.40.16 though