Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] feat: navigation light mode #2730

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

[DO NOT MERGE] feat: navigation light mode #2730

wants to merge 33 commits into from

Conversation

Lelith
Copy link
Collaborator

@Lelith Lelith commented Apr 25, 2024

Purpose of PR

Change the color schema of the Navbar component from dark to light. This is not a new variation but a complete switch of style. The overall structure and layout of the component is unchanged.
But some of the classNames are changed in order to be more meaningful.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2024 •
edited

⚠️ No Changeset found

Latest commit: ab3ce29

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 25, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ❌ Failed (Inspect) Jun 4, 2024 0:58am

@Lelith Lelith force-pushed the feat/navigation_light_mode branch from 52cba3c to f2fcc21 Compare April 25, 2024 10:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 134.79 KB (+0.02% 🔺) 2.7 s (+0.02% 🔺) 159 ms (+141.16% 🔺) 2.9 s
Module 131.19 KB (0%) 2.7 s (0%) 146 ms (+92.38% 🔺) 2.8 s

@damann
Copy link

damann commented Apr 26, 2024

Looks good. Thanks so much! Just two tiny things:
2. There’s something weird happening with the borders of the space switcher not being even.
3. Could you shave off a few pixels on the right margins of the Apps button so that the hover state looks more even between the label and the arrow?
Screenshot 2024-04-26 at 13 33 36
Screenshot 2024-04-26 at 13 45 11

@Lelith Lelith force-pushed the feat/navigation_light_mode branch from 4785d52 to bf171e5 Compare April 29, 2024 11:29
@Lelith Lelith changed the title Feat/navigation light mode feat/navigation light mode Apr 29, 2024
@denkristoffer

This comment was marked as resolved.

Sign in to view
@denkristoffer

This comment was marked as resolved.

Sign in to view
@Lelith Lelith force-pushed the feat/navigation_light_mode branch from e9498cb to bd10031 Compare April 30, 2024 06:34
denkristoffer

This comment was marked as resolved.

Sign in to view

@damann damann marked this pull request as ready for review April 30, 2024 08:38
@damann damann self-requested a review as a code owner April 30, 2024 08:38
Lelith and others added 14 commits May 14, 2024 09:06
@Lelith Lelith force-pushed the feat/navigation_light_mode branch from ad06143 to d1a6baf Compare May 14, 2024 07:24
@Lelith Lelith force-pushed the feat/navigation_light_mode branch from 7d0f364 to d1a6baf Compare May 16, 2024 13:27
@Lelith
feat: introduce size variants for light navbar (#2760)
6736b26 
* feat: set maxWidth for navbar

* feat: enable wide and fullscreen variants

* chore: remove unused import

* feat: only limit the content width not the components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cf-remylenoir cf-remylenoir cf-remylenoir requested changes

@damann damann Awaiting requested review from damann damann is a code owner

@denkristoffer denkristoffer Awaiting requested review from denkristoffer

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
don't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Lelith @damann @denkristoffer @cf-remylenoir @bgutsol @massao