Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DON'T MERGE] feat: update workbench header styles #2451

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

[DON'T MERGE] feat: update workbench header styles #2451

wants to merge 18 commits into from

Conversation

massao
Copy link
Contributor

@massao massao commented Apr 19, 2023 •
edited

@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2023 •
edited

⚠️ No Changeset found

Latest commit: 0c8ba9c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 19, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Jul 7, 2023 10:05am

@github-actions
Copy link

github-actions bot commented Apr 19, 2023 •
edited

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 142.9 KB (0%) 2.9 s (0%) 223 ms (+176.57% 🔺) 3.1 s
Module 139.61 KB (0%) 2.8 s (0%) 109 ms (+2.03% 🔺) 3 s

@massao massao requested a review from fabe April 19, 2023 12:30
@massao massao changed the title feat: update workbench header styles [DON'T MERGE] feat: update workbench header styles Apr 19, 2023
@massao massao marked this pull request as ready for review April 19, 2023 12:37
@massao massao requested review from a team and Lelith as code owners April 19, 2023 12:37
@fabe
Copy link
Member

fabe commented Apr 19, 2023

  • The back button seems too large, I think we've used something different for this in the breadcrumb component?
  • Border bottom should be gray-200
  • The question mark/help icon seems too large, maybe we can use the tiny variant here

@denkristoffer
Copy link
Collaborator

Maybe we should hide [data-test-id="cf-ui-icon"] to remove product icons?

@massao
Copy link
Contributor Author

massao commented Apr 21, 2023 •
edited

Maybe we should hide [data-test-id="cf-ui-icon"] to remove product icons?

We could also just not render the icon at all, keep it on the props to not break anything but don't actually render the icon, since we won't be merging this into main anyway.
NVM, that would probably break tests 🤔

But hiding all [data-test-id="cf-ui-icon"] could also hide elements we don't want to hide, right??

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Marking pull request as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Jun 9, 2023
SofiaMargariti and others added 4 commits July 6, 2023 16:33
@SofiaMargariti
fix: workbench header overflow
aa5d61c 
Set min-width: 0 for workbench header flexboxes
@SofiaMargariti @bgutsol
Update packages/components/workbench/src/WorkbenchHeader/WorkbenchHea…
3c26f53 
…der.tsx

Co-authored-by: Bohdan Hutsol <bohdan.hutsol@contentful.com>
@SofiaMargariti
fix: add icon wrapper only when icon is present
09fac19
@SofiaMargariti
Merge pull request #2520 from contentful/fix/workbench-header-overflow
0c8ba9c 
Set min-width: 0 for workbench header flexboxes
@github-actions github-actions bot removed the stale Used to mark when there was no activity for a set period of time label Jul 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Marking pull request as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Aug 8, 2023
@github-actions github-actions bot removed the stale Used to mark when there was no activity for a set period of time label Sep 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Marking pull request as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Oct 3, 2023
@github-actions github-actions bot removed the stale Used to mark when there was no activity for a set period of time label Jan 18, 2024
@github-actions GitHub Actions
Copy link

Marking pull request as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Feb 17, 2024
@github-actions github-actions bot removed the stale Used to mark when there was no activity for a set period of time label Apr 26, 2024
@github-actions GitHub Actions
Copy link

Marking pull request as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabe fabe fabe approved these changes

@Lelith Lelith Awaiting requested review from Lelith

@bgutsol bgutsol Awaiting requested review from bgutsol bgutsol is a code owner automatically assigned from contentful/team-isotopes

@denkristoffer denkristoffer Awaiting requested review from denkristoffer

@cf-remylenoir cf-remylenoir Awaiting requested review from cf-remylenoir

@damann damann Awaiting requested review from damann damann is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
don't merge stale Used to mark when there was no activity for a set period of time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@massao @fabe @denkristoffer @mshaaban0 @bgutsol @SofiaMargariti