feat: add error handling for selected projects that do not have protection enabled

[rusticpenguin]

Purpose

When a user selects a project, that project may not be setup correctly to be displayed in our Preview. We require the project to have protection bypass enabled.

Approach

• Add logic around checking if the protection bypass is enabled
• Add case to the error reducer

Testing steps

1. Go to Vercel and disable protection bypass for your project
2. Go to your app's config page
3. Select the project with the disabled protection bypass
4. Verify the error message appears below the project selector

[netlify]

✅ Deploy Preview for ecommerce-app-base-components ready!

Name	Link
🔨 Latest commit	623b890
🔍 Latest deploy log	https://app.netlify.com/sites/ecommerce-app-base-components/deploys/66608a7dd6baaf0008d5c007
😎 Deploy Preview	https://deploy-preview-7566--ecommerce-app-base-components.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[lilbitner]

Code looks great George! Thanks for adding those awaits and for always adding clean and readable code.
In terms of functionality, when I test it out locally, I am seeing some clobbering logic within the ProjectSelectionSection file. The two useEffects are essentially overriding each other so the error is not persisting in the UI (as the bypass error is cleared by the validateProjectEnv method. I think we should still follow an approach that there should only exist one error at a time for the project selection step, so perhaps we can combine the useEffects and make the steps sequential in some way? i.e we check that the project has a valid spaceId and then if so, check the bypass token? or vise versa? Also feel free to adjust the logic in the validateProjectEnv method, as it clears all errors if the spaceId is valid, which may not be necessary?

[lilbitner]

Just leaving one comment, curious your thoughts!! (more a UX thing). Awesome work!

[lilbitner]

I think it might be fine to follow the pattern here that we still render the next section even if this error exists, because it is simply a setting they have to change. Just like we allow them to continue to select the next section if the projectSelection.invalidSpaceId is true (which is a setting they need to change). Or perhaps we choose one line of logic or the other! wdyt? See video below for more context (on the weird standard we have for one but not the other). We kind of already have a pattern where things will NOT work with certain configurations but we still allow them to save most of the changes (i.e in the content type/preview path section we allow them to save empty fields even though that clearly won't work).

Screen.Recording.2024-05-16.at.12.53.17.PM.mov

[rusticpenguin]

Sounds good with me!

[lilbitner]

perhaps we remove this line from the conditional then?