check for in docker deployment before setting cgroup #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a docker container from the current master branch works, but when trying to run containernet within the docker container, it does not work, failing with the error
docker.errors.APIError: 400 Client Error: Bad Request ("cgroup-parent for systemd cgroup should be a valid slice named as "xxx.slice"")
The reason for this is the setting of cgroup_parent='/docker' when creating a new Docker Host.
The proposed changes check for the "CONTAINERNET_NESTED" environment variable and if it is set to 1. If true, cgroup_parent will be set to None, allowing execution in docker containers again.