Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run C++ tests in CI; extend C++ tests #157

Open
constantinpape opened this issue Feb 4, 2020 · 0 comments
Open

Run C++ tests in CI; extend C++ tests #157

constantinpape opened this issue Feb 4, 2020 · 0 comments

Comments

@constantinpape
Copy link
Owner

The work @gdkrmr is doing to make his R-bindings uncovers several minor issues in the C++ API, e.g. #156, #154.
The reason this went unnoticed for some time is that C++ tests are currently lacking and are not build / executed in the CI. My current policy was to focus on the python tests, in the hope that this would cover the C++ side as well.

I see now that this approach causes to overlook these smaller issues, so the C++ tests should be run in CI again and possibly also be extended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant