Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify identifier for all handles #152

Open
constantinpape opened this issue Jan 28, 2020 · 0 comments
Open

Unify identifier for all handles #152

constantinpape opened this issue Jan 28, 2020 · 0 comments

Comments

@constantinpape
Copy link
Owner

Currently the handles for different implementation (e.g. FilesystemHandle, S3Handle)
have different members that represent the identifier of the root container (File), e.g. path for filesystem and bucket, bucketName for S3.
The different identifiers need to also be present in the Base class and then need to be implemented by all Deriving clases (where the implementation throws some error if the type of identifier is not appropriate for the deriving class).

The following design would be more elegant:
The handle only has a generic member identifier for this, which stores the container identifier as string. The deriving classes need to cast this to the proper representations internally, e.g. using fs::path for filesystem or by parsing the url for s3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant