This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
A few odd ends #79
Open
A few odd ends #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -863,6 +863,12 @@ func (v *AboutDialog) SetLicenseType(license License) { | |||
| C.gtk_about_dialog_set_license_type(v.native(), C.GtkLicense(license)) | |||
| } | |||
|
|
|||
| // SetLogo is a wrapper around gtk_about_dialog_set_logo(). | |||
| func (v *AboutDialog) SetLogo(logo *gdk.Pixbuf) { | |||
| logoPtr := (*C.GdkDisplay)(unsafe.Pointer(logo.Native())) | |||
There was a problem hiding this comment.
Why is this being cast to a GdkDisplay instead of a GdkPixbuf? Same with SetIcon() below.
|
Rebased, deduplicated, and using GdkPixbuf for pixbufs instead of GdkDisplay |
| @@ -6217,6 +6223,11 @@ func (v *SpinButton) GetValue() float64 { | |||
| return float64(c) | |||
| } | |||
|
|
|||
| // SetRange() is a wrapper around gtk_spin_button_set_range(). | |||
There was a problem hiding this comment.
This project is particular about comment formatting--you'll probably be asked to remove the parens after SetRange.
andre-hub
added a commit
to andre-hub/gotk3
that referenced
this pull request
Feb 13, 2016
AppChoosers and ColorChoosers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small parts from #59 which didn't fit anywhere else