Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a property to deserialize as generic record when specific record class not found #795

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

emersonborges
Copy link

What was done:

  • A new boolean property was created SPECIFIC_AVRO_READER_UNKNOWN_AS_GENERIC_CONFIG. When is true, if SPECIFIC_AVRO_READER_CONFIG is enabled, it will deserialize as generic record if specific record class was not found.
  • Throwing an specific serialization exception class when specific record class not found ( SpecificRecordClassNotFound) to allow consumer to handle properly.

For more details: #791

@ghost
Copy link

ghost commented Apr 29, 2018

It looks like @emersonborges hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@emersonborges
Copy link
Author

[clabot:check]

@ghost
Copy link

ghost commented Apr 29, 2018

It looks like @emersonborges hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@emersonborges
Copy link
Author

[clabot:check]

@ghost
Copy link

ghost commented Apr 29, 2018

@confluentinc It looks like @emersonborges just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@mageshn
Copy link
Member

mageshn commented Oct 15, 2018

@emersonborges Thanks a lot for the PR. I would like to understand a little bit more about the use-case/issue that you are trying to address here. Why would someone choose to configure to use a Specific Record but not have the appropriate class for it? This would help me take this PR forward.

@mageshn mageshn self-requested a review November 8, 2018 20:44
@mageshn
Copy link
Member

mageshn commented Nov 8, 2018

@emersonborges Just wanted to check to see if you had any updates on the question that I had regarding the context for this PR?

@mawek
Copy link

mawek commented Dec 3, 2018

Hello guys - any update on this bug?
It is kind of blocker for us since it happens all the time that there are new events that consumer don't care about, and currently there is no easy way around this since AbstractKafkaAvroDeserializer uses some package protected classes so it can't be easily subclassed and overridden.

@mageshn mageshn removed their request for review June 8, 2021 17:07
@correacaio
Copy link

Hi everyone.
We have the same issue here: our consumer, who only cares about specific events, always breaks when new events are added to the topic. It would be a great improvement if we could configure the deserializer to return a generic record instead of throwing a generic serialization exception. Can I help somehow to develop that feature?

@cla-assistant
Copy link

cla-assistant bot commented Sep 25, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants