Add Scripted Upsert Functionality #759
Open
+340
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
NicholasDCole
changed the title
NicholasDCole
changed the title
NicholasDCole
added a commit
to NicholasDCole/kafka-connect-elasticsearch
that referenced
this pull request
Mar 11, 2024
NicholasDCole
added a commit
to NicholasDCole/kafka-connect-elasticsearch
that referenced
this pull request
Mar 12, 2024
Signed-off-by: Nicholas Cole <nicholas.cole@walmart.com>
Add Kafka Payload -> Injection as Parameters functionality Signed-off-by: Nicholas Cole <nicholas.cole@walmart.com>
NicholasDCole
force-pushed
the
feature/Scripted_Upsert
branch
from
2e04673
to
b6c0645
Compare
|
Please review @sp-gupta @kkonstantine @snehashisp |
1 similar comment
|
Please review @sp-gupta @kkonstantine @snehashisp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Scripted Upserts are not currently possible inside of the Update Request sent to ElasticSearch
Also, the Kafka Payload is always sent in as either doc or upsert.
Solution
Add SCRIPTED_UPSERT write.method and custom logic in DataConverter.java to handle parameter injection as well as script injection into ES UpdateRequest
Does this solution apply anywhere else?
If yes, where?
Test Strategy
Testing done:
Release Plan