Support for max retry backoff time (#750) #756
+116
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pricelessjunk
force-pushed
the
new_max_retry_backoff_time_property
branch
5 times, most recently
from
f0c4640
to
f96de85
Compare
pricelessjunk
changed the title
pricelessjunk
force-pushed
the
new_max_retry_backoff_time_property
branch
from
f96de85
to
0b06a39
Compare
|
@sp-gupta Hello. Could you please take a look at this code. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current max retry back off time is set at a constant of 24 hours. This duration is too long to be practical.
Solution
Making the duration configurable by creating a new property
max.retry.duration.ms. This property has the following featuresretry.backoff.ms(initial backoff time). If a smaller or equal value is set, a warning message is thrown and the default value is selected instead.Does this solution apply anywhere else?
Test Strategy
Testing done:
Release Plan