Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for malformed document error type document_parsing_exception #748

Merged
merged 81 commits into from
May 21, 2024

Conversation

hullarb
Copy link
Contributor

@hullarb hullarb commented Feb 7, 2024

The ignore malformed document configuration is not fully working with the recent version of elasticsearch. This PR adds support for this exception that was introduced lately elastic/elasticsearch@093e36c specifically for document parsing.

Problem

Issue described in #740
Other details explained here: https://confluentinc.atlassian.net/browse/CC-27196

Solution

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

snehashisp and others added 30 commits August 17, 2022 22:38
@hullarb hullarb requested a review from a team as a code owner February 7, 2024 19:10
Copy link

cla-assistant bot commented Feb 7, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 9 committers have signed the CLA.

✅ subhashiyer9
✅ sudeshwasnik
sp-gupta
✅ hullarb
❌ snehashisp
❌ ConfluentJenkins
❌ arihant-confluent
❌ pbadani
❌ Sparsh Gupta


Sparsh Gupta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

cla-assistant bot commented Feb 7, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gladiatr72
Copy link

⬆️

@sp-gupta sp-gupta changed the base branch from master to 10.0.x May 20, 2024 11:35
@sp-gupta sp-gupta requested a review from a team as a code owner May 20, 2024 11:35
@sp-gupta sp-gupta changed the base branch from 10.0.x to master May 20, 2024 11:36
@sp-gupta sp-gupta changed the base branch from master to 14.0.x May 20, 2024 11:54
Copy link
Member

@sp-gupta sp-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @hullarb
Thank you so much for raising the PR and your contribution!

Copy link
Member

@ngupta0205 ngupta0205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sp-gupta sp-gupta merged commit a8db24a into confluentinc:14.0.x May 21, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants