Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'data.stream.namespace' configuration property #742

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fbaligand
Copy link

Problem

Currently, we cannot fully customize the target data stream.
More precisely, the namespace part of the data stream is necessarily the topic.
This is especially a problem, when you want that a connector consumes several topics for only one target data stream.
More simply, I want to be able to define target data stream name, regardless of the input topic name.

Solution

This PR aims to add a new configuration property named 'data.stream.namespace'.
This property aims to customize data stream "namespace" part (as its name says).
This is an optional setting, that have ${topic} as default value ; so that, by default, it works as currently, no breaking change.
By the way, user is able to define a custom namespace that contains topic name like that:
my_prefix_${topic}

Does this solution apply anywhere else?
  • yes
  • [x ] no
If yes, where?

Test Strategy

Testing done:
  • [ x] Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

I guess that you (Confluent Inc.) is responsible for release plan.

I am merging to master

It is safe to revert or rollback

@fbaligand fbaligand requested a review from a team as a code owner January 1, 2024 18:10
Copy link

cla-assistant bot commented Jan 1, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jan 1, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant