Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSERT mode for DELETE operation not send external version #718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ramyogi7283
Copy link

Problem

When UPSERT mode DELETE still sends the version s external that is causing issue.
ELASTIC index snapshot and restore to different environment where Kafka offset values are not same as incremental from snapshot index this external versioning creates problem for DELETE operations even we changes write.method=UPSERT.
#709

Solution

DELETE operation needs to send version external or not based upon the INSERT vs UPSERT method.

Does this solution apply anywhere else?
  • yes
  • [ x ] no
If yes, where?

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

@ramyogi7283 ramyogi7283 requested a review from a team as a code owner September 11, 2023 18:35
@cla-assistant
Copy link

cla-assistant bot commented Sep 11, 2023

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Sep 11, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants