Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose.yml #983

Open
wants to merge 1 commit into
base: 6.1.1-post
Choose a base branch
from

Conversation

mcascallares
Copy link

Automatic observer promotion requires version:2 for log.placement.constraints

Description

What behavior does this PR change, and why?

Author Validation

Describe the validation already done, or needs to be done, by the PR submitter.

Reviewer Tasks

Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.

Automatic observer promotion requires version:2 for log.placement.constraints
@ybyzek
Copy link
Contributor

ybyzek commented Apr 29, 2021

@mcascallares thanks for the PR. Can you please update the description with details and reference links if available? For example, the tutorial appears to work today without this PR -- is that actually not true?

@mcascallares
Copy link
Author

Hi @ybyzek

We just tested it today with version 1, simulating the failover scenario and it didn't work.

@csarrazi discovered this blog post https://www.confluent.io/blog/automatic-observer-promotion-for-safe-multi-datacenter-failover-in-confluent-6-1/ that explicitly states "Automatic Observer Promotion is activated by changing the version of the replica placement policy to two."

Hope this helps!

@ybyzek
Copy link
Contributor

ybyzek commented Apr 29, 2021

We just tested it today with version 1, simulating the failover scenario and it didn't work.

Can you please elaborate on "it didn't work"? What was the symptom? This will help me validate the PR

@mcascallares
Copy link
Author

Sorry, my bad.

"It didn't work" -> when we brought down one of the ISR, and the observerPromotionPolicy was met, it didn't promote one of the observers. @csarrazi discovered that blog post, we switched from v1 to v2 as my PR, and the automatic promotion was triggered.

It is also highlighted in our docs https://docs.confluent.io/platform/current/multi-dc-deployments/multi-region.html#automatic-observer-promotion

@ybyzek
Copy link
Contributor

ybyzek commented Apr 29, 2021

Copy link

cla-assistant bot commented Apr 28, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants