Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANSIENG-3627 Fix lint & doc tests #1592

Merged

Conversation

rrbadiani
Copy link
Member

@rrbadiani rrbadiani commented May 10, 2024

Description

Few changes were needed to pass ansible-sanity and galaxy-importer tests which is necessary for releases on automation hub. To remove errors and warnings from those tests few linting changes are done here. Also molecule and test_roles have been added to ignore list for lint checks

Fixes # (ANSIENG-3627)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

semaphore run

Checklist:

  • Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
  • I have added tests that prove my fix is effective or that my feature works
  • If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@rrbadiani rrbadiani requested a review from a team May 10, 2024 09:28
Copy link

cla-assistant bot commented May 10, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
Copy link

cla-assistant bot commented May 10, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mansisinha
Copy link
Member

Please also add the meta file for variables role, so we don't face that warning

@rrbadiani
Copy link
Member Author

Please also add the meta file for variables role, so we don't face that warning

Yes that is already present

Copy link
Member

@mansisinha mansisinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@rrbadiani rrbadiani merged commit 5534a04 into confluentinc:7.0.x May 15, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants