Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cluster linking metrics #1410

Open
wants to merge 1 commit into
base: 7.4.0-post
Choose a base branch
from

Conversation

danielpetisme
Copy link

Description

Updating the JMX exporter rules to include cluster linking metrics as defined in https://docs.confluent.io/platform/current/multi-dc-deployments/cluster-linking/metrics.html#monitoring-cluster-metrics-and-optimizing-links

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This config is supporting the following demo
https://github.com/vdesabou/kafka-docker-playground/tree/master/other/monitoring-cluster-linking

Checklist:

  • Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
  • I have added tests that prove my fix is effective or that my feature works
  • If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@danielpetisme danielpetisme requested a review from a team as a code owner May 26, 2023 09:47
@wadhwa1 wadhwa1 changed the base branch from 7.4.0-post to 7.0.x May 26, 2023 13:51
@wadhwa1 wadhwa1 changed the base branch from 7.0.x to 7.4.0-post May 26, 2023 13:52
@wadhwa1 wadhwa1 changed the base branch from 7.4.0-post to 7.0.x May 30, 2023 10:51
@wadhwa1 wadhwa1 changed the base branch from 7.0.x to 7.4.0-post May 30, 2023 10:51
type: GAUGE
cache: {{ kafka_broker_jmxexporter_bean_name_expressions_cache | lower }}
labels:
"$1: "$2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"$1: "$2"
"$1": "$2"

@mansisinha
Copy link
Member

Hi @danielpetisme , thanks for your contribution. Please add the missing quotes that I've suggested and raise PR against branch 7.0.x

Copy link

cla-assistant bot commented Oct 31, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants