[CI] list the LICENSE as a license_file #1672
Open
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data files are installed in the wrong directory when packaging this, and it is very uncommon to do so. data files should be files needed for the runtime only.
|
Thanks @dirkmueller @asottile-sentry ! Chose @dirkmueller one because |
|
why not just merge one of the other PRs instead of committing someone else's PR as yourself? |
emasab
force-pushed
the
dev_license_files
branch
from
9fa647c
to
e35e12a
Compare
|
@asottile-sentry the author is still @dirkmueller. We cannot merge directly because our CI won't run on external code and that code could change any moment, so for security reasons. We're still acknowledging contributions in CHANGELOG. |
|
talk about "open source" only in name |
|
We're working on a way to run CI directly on external PRs, still after manual review of its code, so we don't have to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data files are installed in the wrong directory when packaging this, and it is very uncommon to do so. data files should be files needed for the runtime only.