[KIP-848] Make Kafka integration test run with new protocol too #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emasab
force-pushed
the
dev_kip848_integration_tests
branch
from
3c14612
to
9bc9e08
Compare
emasab
force-pushed
the
dev_kip848_integration_tests
branch
from
9bc9e08
to
d287a0f
Compare
emasab
force-pushed
the
dev_kip848_integration_tests
branch
from
e158587
to
5761e43
Compare
anchitj
requested changes
Apr 26, 2024
Comment on lines
+21
to
+27
| var groupProtocol = TestConsumerGroupProtocol.GroupProtocol(); | ||
| if (groupProtocol != null) | ||
| { | ||
| consumerConfig.GroupProtocol = groupProtocol == "classic" ? | ||
| GroupProtocol.Classic : | ||
| GroupProtocol.Consumer; | ||
| } |
There was a problem hiding this comment.
Can be simplified using TestConsumerGroupProtocol.IsClassic()
There was a problem hiding this comment.
I left it like it is because TestConsumerGroupProtocol.IsClassic() returns true even if it's not set, and in that case we don't want to set property explicitly but rely on the default
| @@ -94,7 +94,7 @@ private void LogToFile(string msg) | |||
| { | |||
| // Uncomment to enable logging to a file. Useful for debugging, | |||
| // for example, which test caused librdkafka to segfault. | |||
| // File.AppendAllLines("/tmp/test.txt", new [] { msg }); | |||
| File.AppendAllLines("/tmp/test.txt", new [] { msg }); | |||
is still not available
emasab
force-pushed
the
dev_kip848_integration_tests
branch
11 times, most recently
from
c6c35e6
to
4e1451d
Compare
emasab
force-pushed
the
dev_kip848_integration_tests
branch
from
4e1451d
to
c00d90e
Compare
anchitj
reviewed
May 6, 2024
anchitj
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.