Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NJsonSchema to v11 #2185

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update NJsonSchema to v11 #2185

wants to merge 2 commits into from

Conversation

NoahStolk
Copy link

@NoahStolk NoahStolk commented Feb 5, 2024 •
edited

A few notes:

  • This is a breaking change, and should be included in a major version release only, as we're dropping support for NJsonSchema v10. This change will impact users that manage their own references to NJsonSchema v10.
  • Newtonsoft.Json-based generators have been moved to a separate NuGet package, so the reference to NJsonSchema has been replaced with a reference to NJsonSchema.NewtonsoftJson. See NSwag 14 announcement and NJsonSchema v11 release notes.
  • EnumHandling no longer exists, so the WithJsonSchemaGeneratorSettingsSerDe unit test has been updated to use JsonSerializerSettings instead.

Related issue: #2169

@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Feb 5, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@NoahStolk NoahStolk marked this pull request as ready for review February 14, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KB-RBullock KB-RBullock KB-RBullock approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NoahStolk @KB-RBullock