Add support for directory URIs #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domibarton
reviewed
Mar 25, 2021
| # the Tracks. Right now it is not possible to get the type of an | ||
| # URI. So we just try to browse uri and if it is not a directory | ||
| # this will return an empty list of uris. | ||
| uris = cls._browse_uri(core, uri) |
There was a problem hiding this comment.
@ueb Are you sure this is working? Because the method doesn't seem to return anything :/
There was a problem hiding this comment.
Sorry, I did test the wrong branch.
It is working now. Tested it with:
- a single file
- a directory without subdirectories
- a driectory with subdirectories
There was a problem hiding this comment.
Can you please ensure the tests are running successful:
pylint mopidy_pummeluff
************* Module mopidy_pummeluff.actions.tracklist
mopidy_pummeluff/actions/tracklist.py:26:0: C0303: Trailing whitespace (trailing-whitespace)
mopidy_pummeluff/actions/tracklist.py:28:31: C0303: Trailing whitespace (trailing-whitespace)
mopidy_pummeluff/actions/tracklist.py:62:0: C0303: Trailing whitespace (trailing-whitespace)
mopidy_pummeluff/actions/tracklist.py:63:8: W1202: Use % formatting in logging functions and pass the % parameters as arguments (logging-format-interpolation)
************* Module mopidy_pummeluff.actions.__init__
mopidy_pummeluff/actions/__init__.py:1:0: R0801: Similar lines in 2 files
==mopidy_pummeluff.actions.__init__:4
==mopidy_pummeluff.actions.playback:4
__all__ = (
'PlayPause',
'Stop',
'PreviousTrack',
'NextTrack', (duplicate-code)
Allows the user to assign directory URIs to an RFID tag. All Tracks in the referenced directory and its sub directories will be added to the tracklist.
|
This PR should now generate no new errors in py lint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to assign directory URIs to an RFID tag.
All Tracks in the referenced directory and its sub directories
will be added to the tracklist.