Dynamic IP handling #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Query DHCP leases for clients that only have an alias not an actual fixed IP.
Change from 'fixed_ip' to 'use_fixedip' field in client record to handle configured clients without a saved fixed IP. Added handling for configured clients that have no current fixed or DHCP IP, ie offline in the case of DHCP clients.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi There,
I knew I should have figured out how to make a PR sooner :)
I made some changes to the script to handle devices that have been given an Alias, but not a fixed IP, ie they are on DHCP. A few devices do not register nice hostnames with DHCP, this allows those names to be overridden with an alias.
use_fixedipfield appears to always be present for a 'configured' client, thefixed_ipfield is not always present.There is probably better ways to query the DHCP leases, but this seems to work fine on my small network.
Disclaimer: The sum total of my Python experience is as long as it took to figure out how to make these changes :)
Cheers.