Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support different names for base and non-base environment #180
Support different names for base and non-base environment #180
Changes from 8 commits
b9e7cfa
1f9bbd4
03b40fd
5f0e051
42e769a
7272333
2af02fb
0e7113a
4a7be20
6f7300b
d3d6d9c
3d0e36e
7b83395
c223f5f
8f39521
422dbb8
1de5f43
1909ef0
46e7795
932f80c
c6730eb
ca9f608
dce5666
bc92af7
1d5f1be
ca52e2d
9b87330
0ab1e24
8516d46
fef15d0
2249a94
9588b89
f186e8c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be false-y? 🤔 I think we don't need the
or ""
part, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I look at it again, I don't think so. I guess I was overly cautious here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point we have not rendered the
{{ variables }}
, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct.
The tests for a dictionary representation of the name would have failed by then, so even if code changes render the name at that point, the tests will catch that.