Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python matrix (add 3.10, 3.11, 3.12 - drop 3.7) #231

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Callek
Copy link

@Callek Callek commented Mar 4, 2024

Description

  • Removes python 3.7
    • Because conda no longer supports 3.7
  • Adds python 3.10, 3.11, and 3.12
    • All Supported by conda now

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?
    • I don't see any documentation that shows the python version range

Extra Note

In python 3.12 this now raises the following warning:

DeprecationWarning: Python 3.14 will, by default, filter extracted tar archives and reject files or modify their metadata. Use the filter argument to control this behavior.

That relates to https://docs.python.org/3/library/tarfile.html#extraction-filters and specifically in 3.8->3.12 an non-specified filter will default to fully_trusted which may not be secure. I went with not altering the behavior in this PR, but a followup issue should be filed/acted on to decide how we want to proceed.

This is a warning that is also present on 3.12 CI for conda itself.

@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @Callek.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#889), and ping the bot to refresh the PR.

@kenodegard
Copy link
Contributor

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 4, 2024
Callek added a commit to Callek/conda-package-handling that referenced this pull request Mar 4, 2024
Callek added a commit to Callek/conda-package-handling that referenced this pull request Mar 4, 2024
@Callek Callek marked this pull request as ready for review March 4, 2024 21:59
@@ -1,6 +1,7 @@
"""
Simple test for evaluating zstandard binding memory usage.
"""

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must have been added by black 24.x since I ran that here.

news/python-update Outdated Show resolved Hide resolved
news/python-update Outdated Show resolved Hide resolved
@jaimergp jaimergp mentioned this pull request Apr 23, 2024
Callek and others added 2 commits May 7, 2024 15:16
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
@Callek Callek requested a review from jaimergp May 7, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

None yet

4 participants