Add support for base_url #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
dholth
commented
Apr 8, 2024
|
Should we add base_url to index.html also? Would need to be applied to all package filenames but not repodata.json. |
dholth
commented
Apr 8, 2024
| @@ -499,8 +500,10 @@ def __init__( | |||
| write_zst=False, | |||
| write_run_exports=False, | |||
| compact_json=True, | |||
| *, | |||
There was a problem hiding this comment.
make newer arguments keyword-only and not passable by position
jezdez
reviewed
Apr 15, 2024
Co-authored-by: Jannis Leidel <jannis@leidel.info>
jezdez
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for base_url. Fix #150
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?