use actual platform-specific perl path during TEST stage
#5160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @jvolkening. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#873), and ping the bot to refresh the PR. |
|
I signed the CLA |
jvolkening
force-pushed
the
fix_perl_win_test
branch
from
892023e
to
7df24da
Compare
conda-bot
added
the
cla-signed
jaimergp
reviewed
Mar 25, 2024
| @@ -3235,7 +3235,7 @@ def _write_test_run_script( | |||
| tf.write( | |||
| '"{perl}" "{test_file}"\n'.format( | |||
| perl=metadata.config.perl_bin( | |||
| metadata.config.test_prefix, metadata.config.host_platform | |||
| metadata.config.test_prefix, sys.platform | |||
There was a problem hiding this comment.
Shouldn't this be metadata.config.build_platform?
There was a problem hiding this comment.
Not entirely sure, but I can't see where that is defined or used in the codebase. sys.platform seems to be used in a number of places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In troubleshooting some failed win_64 CI builds for PRs submitted to conda-forge staged-recipes (conda-forge/staged-recipes#25137), I believe I narrowed the failed tests to the fact that the path determined for
perlin the code modified here was setting the wrong path. Specifically, although these arenoarch: genericrecipes, they are being tested by thestaged-recipesCI on Windows in addition to Linux and OSX. Since the value ofmetadata.config.host_platformhere is set tonoarchbut the code that sets the path toperlis testingif platform.startswith("win"):, the resulting path is incorrect.I saw another issue and commit relating to the use of
host_platforminstead ofsys.platformin another part of the codebase in order to enable cross-compiling. In this instance, I can't foresee a situation in which the command string being built up inwrite_test_scriptswould be run byteston a platform different from that on which it was called.I haven't performed the points below yet, but I will if the change proposed seems valid. I'd like to get feedback on the change first.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?