Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C compiler dep when .xs files are found. #4599

Merged
merged 5 commits into from
Mar 7, 2023

Conversation

xileF1337
Copy link
Contributor

@xileF1337 xileF1337 commented Oct 11, 2022

Description

For many Perl modules, a C compiler dependency is not added to meta.yaml created by conda skeleton cpan even though it is required. This is because C files for Perl modules are commonly stored in files with .xs extension, which are not currently recognized by conda skeleton cpan. This PR adds detection for the .xs extension such that the required dependencies are automatically added. This fixes #4598.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 11, 2022
@xileF1337
Copy link
Contributor Author

The pre-commit CI job fails due to tests/test_index.py:206:5: E303 too many blank lines (2), but I have not touched this file. So it is not my job to fix it I guess?

Felix Kuehnl added 2 commits November 3, 2022 20:42
Copy link
Member

@mbargull mbargull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this!
There aren't many people knowledgeable about these things in our community, so I very much appreciate your input. Also, thanks for the detailed description in gh-4598 -- very helpful to properly review this without needing to learn the ins and outs of Perl packaging :).
Sorry it took so long to get this reviewed. Not many/any of us are involved with Perl (packaging), plus conda-skeleton will likely be deprecated (see gh-4640) which is why it's not high on anyone's (long) ToDo list, I suppose...

That said, the changes are fine and contained to skeleton.cpan, so I hope this is okay to be merged soon!

@xileF1337
Copy link
Contributor Author

xileF1337 commented Dec 16, 2022

Thanks for improving this! There aren't many people knowledgeable about these things in our community, so I very much appreciate your input. Also, thanks for the detailed description in gh-4598 -- very helpful to properly review this without needing to learn the ins and outs of Perl packaging :). Sorry it took so long to get this reviewed. Not many/any of us are involved with Perl (packaging), plus conda-skeleton will likely be deprecated (see gh-4640) which is why it's not high on anyone's (long) ToDo list, I suppose...

I'm glad if I could help. I understand that Perl support does not have a super high priority for people who don't use it themselves. Still, it would be a lot more motivating for further contributions to get feedback a little bit faster, especially for one-line fixes to severe bugs. I still appreciate that you are taking care of this now. Concerning the deprecation of conda skeleton: I suppose this will still take a while since there is currently not even R/CRAN support implemented in the successor grayskull, not to speak of Perl/CPAN. I hope that conda skeleton will be supported until this is available ...

That said, the changes are fine and contained to skeleton.cpan, so I hope this is okay to be merged soon!

That would be awesome, thank you!

@xileF1337
Copy link
Contributor Author

@mbargull, happy new year! Are we ready to merge here? Thanks for your support!

@xileF1337
Copy link
Contributor Author

Hey @mbargull, is there anything left to do here except for pushing the merge button? Thanks for your time!

@xileF1337
Copy link
Contributor Author

@mbargull It would be awesome if you could just push that button! Thank you so much!

@kenodegard
Copy link
Contributor

@xileF1337 Again, thanks for working on this. As @mbargull alluded to Perl and conda skeleton has unfortunately not been a strong suite for the development team so it fell through the cracks. If you want to learn more about what we are doing to try to rectify these issues check out #4697.

@mbargull Thanks as always.

@kenodegard kenodegard merged commit f7e8bc3 into conda:main Mar 7, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

conda skeleton cpan should add a C compiler dep if a module contains xs files
4 participants