Move CLI's logging initialization into a dedicated module #5275
Conversation
conda-bot
added
the
cla-signed
CodSpeed Performance ReportMerging #5275 will not alter performanceComparing Summary
|
|
@kenodegard this sadly needs a merge :-/ |
|
|
||
| # set filelock's logger to only show warnings by default | ||
| logging.getLogger("filelock").setLevel(logging.WARN) |
There was a problem hiding this comment.
AFAIK this is also no longer necessary since we've restored the root logger to warning, see conda_build.cli.logging.init_logging.
| logging.getLogger("conda.core.linked_data").setLevel(logging.WARN) | ||
| logging.getLogger("conda.gateways.disk.delete").setLevel(logging.WARN) | ||
| logging.getLogger("conda.gateways.disk.test").setLevel(logging.WARN) |
There was a problem hiding this comment.
AFAIK this is unnecessary since logging.WARNING is already the default log level in conda.
| # undo conda messing with the root logger | ||
| logging.getLogger(None).setLevel(logging.WARNING) |
There was a problem hiding this comment.
To remove this we will first need to remove initialize_root_logger from conda's log initialization (and then wait some number of conda releases until we can bump up conda-build's minimum conda dependency): https://github.com/conda/conda/blob/eb459543b0c280011216f2f22eedc1c8dcbd4d9f/conda/gateways/logging.py#L142-L147
Description
Refactor
conda_build.utils.get_loggerintoconda_build.cli.logging.init_loggingand only call this initializer when the conda-build CLI entrypoints are invoked. When using conda-build as a library we do not set any logging defaults.Resolves #5274
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?