Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit more CUDA versions #17

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mabraham
Copy link
Contributor

@mabraham mabraham commented Jun 5, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mabraham
Copy link
Contributor Author

mabraham commented Jun 5, 2023

@conda-forge-admin please rerender

@mabraham
Copy link
Contributor Author

mabraham commented Jun 5, 2023

Motivating discussion at #15 (comment)

@mabraham mabraham mentioned this pull request Jun 5, 2023
@douglowe
Copy link
Contributor

douglowe commented Jun 5, 2023

Looks like we need a build matrix to define which CUDA versions to build for - so we aren't trying to build for cuda 10.2 (and earlier).

@mabraham
Copy link
Contributor Author

mabraham commented Jun 5, 2023

@conda-forge-admin please rerender

@mabraham
Copy link
Contributor Author

mabraham commented Jun 5, 2023

@conda-forge-admin please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [50]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Regarding cicc this should be in $BUILD_PREFIX/nvvm/bin

Could you please share some more details on what is calling cicc (if known)?

From a cursory look at this recipe (and the upstream code), didn't see cicc, but that is more likely because I don't know where to look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants