Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rel="alternate" hreflang tag should not exclude language of page itself. #41

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hissy
Copy link
Contributor

@hissy hissy commented Oct 2, 2013

I watched a video below. Google says "hreflang should specify all alternates on eace page, including the page itself", but multilingual add-on does not.

Expanding your site to more languages (about 9:49)
http://www.youtube.com/watch?v=8ce9jv91beQ

https://support.google.com/webmasters/answer/189077

Multilingual sitemap already has alternates of all languages.

hissy and others added 2 commits October 3, 2013 00:51
Let's avoid calling getTranslatedPageWithAliasSupport when $otherLang is
the language of the current page.
Faster calculation of hreflang tags
@tylerryan
Copy link
Contributor

Hi Guys,
I was looking to merge this one, but I'm not sure I completely understand this.
In my test site I have two locales setup: en_US and es_MX. With this merged locally I only get one hreflang showing the related page, not the current page.

Also this feature is commented out in the controller.
https://github.com/concrete5/addon_internationalization/blob/master/packages/multilingual/controller.php#L39
It would be good to add this as an option to the setup page dashboard ui. I know I've had this slow large sites down when there are allot of locales setup.

Best,
Ryan

@mlocati
Copy link
Contributor

mlocati commented Apr 22, 2014

This feature is implemented here: https://github.com/concrete5/addon_internationalization/blob/master/packages/multilingual/controller.php#L72
Maybe you should set define MULTILINGUAL_ADD_ALTERNATE_HREFLANG as true in your config/site.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants