-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(editor) Remove our console proxy and the console tab #5676
Conversation
#12437 Bundle Size — 62.12MiB (-0.66%).
Warning Bundle removed 6 duplicate packages, 52 duplicate packages remaining – View duplicate packages Bundle metrics
|
Current #12437 |
Baseline #12435 |
|
---|---|---|
Initial JS | 45.18MiB (-0.9% ) |
45.59MiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 26.96% |
21.16% |
Chunks | 31 |
31 |
Assets | 34 |
34 |
Modules | 4276 (-2.51% ) |
4386 |
Duplicate Modules | 509 (-0.39% ) |
511 |
Duplicate Code | 31.01% (+0.62% ) |
30.82% |
Packages | 449 (-4.06% ) |
468 |
Duplicate Packages | 52 (-10.34% ) |
58 |
Bundle size by type 2 changes
2 improvements
Current #12437 |
Baseline #12435 |
|
---|---|---|
JS | 62.11MiB (-0.66% ) |
62.53MiB |
HTML | 10.94KiB (-0.34% ) |
10.98KiB |
Bundle analysis report Branch chore/remove-console-proxy Project dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
firstLine.startsWith(ReactRouterAwaitErrorPrefix) | ||
) { | ||
// ...Mark these as having been seen. | ||
setReactRouterErrorHasBeenLogged(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In PR #5084 this was added so that if a change caused an exception in something like an <Await>
component, that a further change would result in the error being cleared. Does that now work without this logic?
Problem:
The console pane is useless.
Fix:
Remove it.
Manual Tests:
I hereby swear that:
Fixes #5631