Close context menu on escape #5656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#12359 Bundle Size — 62.46MiB (~+0.01%).
Warning Bundle contains 58 duplicate packages – View duplicate packages Bundle metrics
|
| Current #12359 |
Baseline #12344 |
|
|---|---|---|
 Initial JS |
45.54MiB(~+0.01%) |
45.54MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.09% |
21.69% |
| Chunks |
31 |
31 |
| Assets |
34 |
34 |
| Modules |
4374 |
4374 |
| Duplicate Modules |
504 |
504 |
| Duplicate Code |
30.82% |
30.82% |
| Packages |
468 |
468 |
| Duplicate Packages |
58 |
58 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #12359 |
Baseline #12344 |
|
|---|---|---|
| JS |
62.45MiB (~+0.01%) |
62.45MiB |
| HTML |
10.94KiB (-0.34%) |
10.97KiB |
Bundle analysis report Branch fix/context-menu-close Project dashboard
|
Performance test results: |
liady
requested review from
gbalint,
seanparsons,
Rheeseyb,
ruggi,
balazsbajorics,
maltenuhn,
benwolfram and
bkrmendy
and removed request for
maltenuhn
Rheeseyb
approved these changes
May 13, 2024
seanparsons
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Today "Escape" only clears the filter text but doesn't close the context menu
Fix:
Clear the text only if there is a text, otherwise close the context menu
Monosnap.screencast.2024-05-09.19-33-42.mp4