Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike: update metaobject from Utopia #5448

Draft
wants to merge 74 commits into
base: master
Choose a base branch
from
Draft

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented May 1, 2024

Flow

  • the new value is typed in in the inspector, submitted with Enter
  • a function called requestUpdate generates the graphql query based on the new value, the data path leading the prop value, and the loader's return value. requestUpdate is defined inside the remix route module and we read it like we read loader, action etc. The responsibility of requestUpdate is to "connect" what's returned from the loader to how that data can be updated
  • we send the graphql query to the BFF, which posts it to the Shopify admin API. The reason the BFF makes the fetch call is because the admin api needs an API key that we don't want to expose in the client
  • the metaobject value is updated
  • wait/refresh (repeat if necessary)
  • see the new value

Copy link
Contributor

github-actions bot commented May 1, 2024

Try me

Copy link

relativeci bot commented May 1, 2024

#12323 Bundle Size — 62.51MiB (+0.05%).

9ac398b(current) vs 6339ece master#12320(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 1 regression
                 Current
#12323
     Baseline
#12320
Regression  Initial JS 45.59MiB(+0.07%) 45.55MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.76% 21.74%
No change  Chunks 31 31
No change  Assets 34 34
Change  Modules 4381(+0.07%) 4378
No change  Duplicate Modules 504 504
Change  Duplicate Code 30.8%(-0.03%) 30.81%
No change  Packages 468 468
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#12323
     Baseline
#12320
Regression  JS 62.5MiB (+0.05%) 62.47MiB
Improvement  HTML 10.94KiB (-0.34%) 10.98KiB

Bundle analysis reportBranch spike/update-metaobjectProject dashboard

Copy link
Contributor

github-actions bot commented May 1, 2024

Performance test results:
(Chart1)
(Chart2)

balazsbajorics and others added 30 commits May 2, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants