New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change specificity of store when rendering canvas controls #5432

Draft

liady wants to merge 1 commit into master from fix/new-controls-render

Contributor

liady commented Apr 30, 2024

Problem:
Describe the problem being addressed as succinctly as possible.

Fix:
Describe the fix you have made as succinctly as possible.

Commit Details: (< vv pls delete this section if's not relevant)

Renamed thing to otherThing
Removed cake from fridge-contents.ts
Did [other things]

Manual Tests:
I hereby swear that:

I opened a hydrogen project and it loaded
I could navigate to various routes in Preview mode

Fixes #[ticket_number] (<< pls delete this line if it's not relevant)


          selective store

b968b0e

Contributor

github-actions bot commented Apr 30, 2024 •

edited

Try me

relativeci bot commented Apr 30, 2024

#12006 Bundle Size — 62.36MiB (~+0.01%).

b968b0e(current) vs 6339ece master#11995(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics

Change

2 changes

Regression

1 regression

	Current #12006	Baseline #11995
Initial JS	`45.44MiB`(`~+0.01%`)	`45.44MiB`
Initial CSS	`0B`	`0B`
Cache Invalidation	`21.62%`	`20.93%`
Chunks	`31`	`31`
Assets	`34`	`34`
Modules	`4371`	`4371`
Duplicate Modules	`503`	`503`
Duplicate Code	`30.81%`	`30.81%`
Packages	`467`	`467`
Duplicate Packages	`58`	`58`

Bundle size by type

Change

2 changes

Regression

1 regression

Improvement

1 improvement

	Current #12006	Baseline #11995
JS	`62.35MiB` (`~+0.01%`)	`62.34MiB`
HTML	`10.94KiB` (`-0.34%`)	`10.98KiB`

Bundle analysis report Branch fix/new-controls-render Project dashboard

Contributor

github-actions bot commented Apr 30, 2024

Performance test results:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment