Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSX text blocks in element props #5136

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

JSX text blocks in element props #5136

wants to merge 3 commits into from

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Mar 28, 2024 •
edited

Description

This PR improves that parser so that string in element props are parsed as JSX_TEXT_BLOCK instead of ARBITRARY_JS

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Mar 28, 2024 •
edited

Job #11338: Bundle Size — 63.24MiB (~+0.01%).

58c9c97(current) vs 2296c28 master#11331(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #11338		      Baseline
Job #11331
Regression  Initial JS 50.42MiB(~+0.01%) 50.42MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 22.57% 18.76%
No change  Chunks 40 40
No change  Assets 44 44
No change  Modules 4459 4459
No change  Duplicate Modules 598 598
No change  Duplicate Code 31.92% 31.92%
No change  Packages 467 467
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #11338		      Baseline
Job #11331
Regression  JS 63.23MiB (~+0.01%) 63.22MiB
Improvement  HTML 14.15KiB (-0.44%) 14.21KiB

View job #11338 report View feature/jsx-text-block-in-prop branch activity View project dashboard

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited

Performance test results:
(Chart1)
(Chart2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bkrmendy