Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Remove BFF check #5132

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

(chore) Remove BFF check #5132

wants to merge 8 commits into from

Conversation

liady
Copy link
Contributor

@liady liady commented Mar 27, 2024

Removes all BFF checks from the code. This should be merged only when BFF is turned on in all environments.

Copy link
Contributor

github-actions bot commented Mar 27, 2024

Try me

Copy link

relativeci bot commented Mar 27, 2024

#12753 Bundle Size — 61.91MiB (-0.53%).

70d273e(current) vs 6339ece master#12752(baseline)

Warning

Bundle contains 51 duplicate packages – View duplicate packages

Bundle metrics  Change 5 changes Improvement 2 improvements
                 Current
#12753
     Baseline
#12752
Improvement  Initial JS 44.98MiB(-0.73%) 45.31MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 26.28% 22.06%
No change  Chunks 30 30
No change  Assets 33 33
Change  Modules 4287(-0.12%) 4292
Improvement  Duplicate Modules 516(-0.96%) 521
Change  Duplicate Code 31.44%(-1.1%) 31.79%
No change  Packages 448 448
No change  Duplicate Packages 51 51
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#12753
     Baseline
#12752
Improvement  JS 61.9MiB (-0.53%) 62.23MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis reportBranch chore/remove-bffProject dashboard

Copy link
Contributor

github-actions bot commented Mar 27, 2024

Performance test results:
Highlight Regular (-7%)
Before: 8.9ms (7.5-12.7ms)
After: 8.3ms (6.9-12.5ms)

Highlight All Elements (2%)

Selection (1%)

De-Selection (3%)

Selection Change (0%)

Scroll Canvas (24%)
Before: 4.2ms (3.2-6.7ms)
After: 5.2ms (3.2-13.7ms)

(Chart1)
(Chart2)

@liady liady marked this pull request as ready for review April 8, 2024 13:58
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Performance test results:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants