SPIKE: add require info to component #5125
Draft
+217
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature/component-registration-component-import-check
…to feature/component-registration-component-import-check
…to feature/component-registration-component-import-check
gbalint
changed the base branch from
master
to
feature/component-registration-component-import-check
Job #11302: Bundle Size — 63.23MiB (+0.01%).
Warning Bundle contains 58 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #11302 report View spike/require-info-2 branch activity View project dashboard |
|
Performance test results: |
Base automatically changed from
feature/component-registration-component-import-check
to
master
March 27, 2024 15:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We need to access the name and the module of an imported external component
Fix:
In our require function, extend the component with these new symbol properties
Check if this name equals to the key in
isComponentRegistrationValid(when the name is there).