Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sysroot property #16011

Merged

Conversation

ErniGH
Copy link
Contributor

@ErniGH ErniGH commented Apr 3, 2024

Changelog: Fix: Handle tools.build:sysroot on Meson toolchain
Docs: https://github.com/conan-io/docs/pull/XXXX

Close: #14987

I added the sys_root to the Meson properties and the --sysroot=sys_root flag on c_args, cpp_args, c_link_args and cpp_link_args.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@memsharded memsharded added this to the 2.4.0 milestone May 8, 2024
@memsharded
Copy link
Member

Assigning this PR to @franramirez688 for Conan 2.4, otherwise it will slip

Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A couple of things 😉

conan/tools/meson/toolchain.py Outdated Show resolved Hide resolved
test/functional/toolchains/meson/test_meson.py Outdated Show resolved Hide resolved
@franramirez688 franramirez688 merged commit b6c53b3 into conan-io:develop2 May 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] MesonToolchain does not handle tools.build:sysroot
5 participants