changing order of name to check (#45)

* changing order of name to check
* remove ipython import
* need to check both orders
* better way to specify delim

Signed-off-by: vsoch <vsochat@stanford.edu>

CHANGELOG.md

@@ -14,6 +14,7 @@ and **Merged pull requests**. Critical items to know are:
 The versions coincide with releases on pip.
 
 ## [0.0.x](https://github.com/con/tributors/tree/master) (0.0.x)
+ - searching for last, first and reverse for orcid lookup (0.0.18)
  - unicode characters allowed, and dont update users with orcids (0.0.17)
  - should allow for repository names with .git extension (0.0.15)
  - adding support to do updates `--from` (between) resources (0.0.14)

tributors/main/orcid.py

@@ -176,12 +176,33 @@ def get_orcid(email, token, name=None):
 
     # Attempt # 2 will use the first and last name
     if name is not None and not orcid_id:
-        parts = name.split(" ")
-        first, last = parts[0], " ".join(parts[1:])
+
+        # If no comma, likely a space delimiter
+        delim = "," if "," in name else " "
+        cleaner = "," if delim == " " else " "
+
+        parts = name.split(delim)
+        last, first = parts[0].strip(cleaner), " ".join(parts[1:]).strip(cleaner)
         url = (
             "https://pub.orcid.org/v3.0/search/?q=given-names:%s+AND+family-name:%s"
             % (first, last)
         )
         orcid_id = record_search(url, token, name)
 
+        # Attempt # 3 will try removing the middle name
+        if " " in first:
+            url = (
+                "https://pub.orcid.org/v3.0/search/?q=given-names:%s+AND+family-name:%s"
+                % (first.split(" ")[0].strip(), last)
+            )
+            orcid_id = record_search(url, token, name)
+
+        # Attempt # 4 will reverse (some orcid entries are last, first, others the opposite
+        if orcid_id is None:
+            url = (
+                "https://pub.orcid.org/v3.0/search/?q=given-names:%s+AND+family-name:%s"
+                % (last, first)
+            )
+            orcid_id = record_search(url, token, name)
+
     return orcid_id

tributors/version.py

@@ -8,7 +8,7 @@
 
 """
 
-__version__ = "0.0.17"
+__version__ = "0.0.18"
 AUTHOR = "Vanessa Sochat"
 AUTHOR_EMAIL = "vsochat@stanford.edu"
 NAME = "tributors"