Install update for non-standard elements #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have had more report of users that could not install and got a Unable to write entry. Noticed today that the two elements packager and packagerurl were non-standard, and after removing files installed as should.
The values translated_entities and untranslated_entities are available in the incoming data, and can be used for a calculation of percentage completed that take into account the weight of the individual resources. As it is now, a 1 string resource and a 6500 strings resource have the same weight, and this doesnt give the correct value in front overview.
More preparation for calculation of percentage using untranslated_entities and translated_entities
Using the new values translated_entities and untranslated_entities to have a calculation that take into account that resources have different weight. Now the percentage will show completed of basis of all strings in a project.
Preparing db to allow to set a minimum percentage of which packages to show in frontend
Added minimum_perc in projects to the update script
Adding this field to allow limit by percentage completed which packages are shown in frontend. This allow you to not have all the 0% empty packages shown, by setting the value you prefer.
This adds a field where you can enter a minimum percentage for limiting what is shown in frontend view.
Added string and label string for the new minimum percentage setting
By default ctransifex list all the incoming packages, also the 0% ones, and by allowing to set a minimum percentage you can decide which packages you wish to show in frontend view. The value can be set individually for each project.
|
Added 4 commits to change how frontend % completed is calculated. Now reflect the overall translated percentage |
|
Added 6 commits for to allow to set a value in individual project config, to limit the frontend view to a predefined percentage. Allows you to only show packages that are completed equal to or higher than the set percentage |
Noticed that script stopped when a project only had one type of extension files, for example only admin files and no site files. A simple check for $files seems to solve that so packages are built also when only having one type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have had more report of users that could not install and got a Unable to write entry. Noticed today that the two elements packager and packagerurl were non-standard, and after removing files installed as should.