Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Interview Export Errors #90

Merged
merged 5 commits into from Mar 4, 2024
Merged

Fix: Interview Export Errors #90

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c621c41
fix: security issues with programatic download
buckhalt Feb 29, 2024
0c7c15b
Revert "fix: security issues with programatic download"
buckhalt Feb 29, 2024
0498592
fix: export errors
buckhalt Feb 29, 2024
fd1893f
fix: access control checks errors
buckhalt Feb 29, 2024
223f181
Revert "fix: access control checks errors"
buckhalt Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion app/(dashboard)/dashboard/interviews/_components/ExportInterviewsDialog.tsx
View file
Open in desktop
Expand Up @@ -74,8 +74,16 @@ export const ExportInterviewsDialog = ({
throw new Error(e.message);
}

const response = await fetch(result.data.url);
const blob = await response.blob();

// create a download link
const url = URL.createObjectURL(blob);

// Download the zip file
download(result.data.url, result.data.name);
download(url, result.data.name);
// clean up the URL object
URL.revokeObjectURL(url);
} catch (error) {
toast({
icon: <XCircle />,
Expand Down
5 changes: 5 additions & 0 deletions components/ErrorReportNotifier.tsx
View file
Open in desktop
Expand Up @@ -67,6 +67,11 @@ export default function ErrorReportNotifier({ error }: { error: Error }) {
if (initialized.current) return;
setState('loading');

// limit size of error.stack
if (error.stack && error.stack.length > 500) {
error.stack = error.stack.substring(0, 500);
}

buckhalt marked this conversation as resolved.
Show resolved Hide resolved
trackEvent({
type: 'Error',
name: error.name,
Expand Down