Don't trust hasStackUsageOutput/hasOptOutput
#6471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or compilations that failed and really have no `stackUsageOutput`/`optOutput`
|
You're right that just checking if the response has the fields should be enough - Happy to merge as-is, but maybe a less breaking change for now until we investigate/improve that is to check for both variables? wdyt? |
|
Thanks! |
|
This is rolling out now, thanks ofek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... they can be true for compilations that failed and really have no
stackUsageOutput/optOutputThis fixes #6468 alright, but I'm not sure about the followup questions:
(1) Is there really a point in keeping the boolean members
hasStackUsageOutput/hasOptOutput?(2) What about other
has*members -hasPpOutput,hasAstOutput,hasIrOutputetc? I didn't give them similar treatment as I couldn't reproduce similar problems.I tend to stick with this quick-n-dirty-ish solution but would appreciate opinions.