Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stack-usage display inline, same as opt-view #6469

Merged
merged 4 commits into from May 14, 2024

Conversation

OfekShilon
Copy link
Member

@OfekShilon OfekShilon commented May 11, 2024

Following the intention declaration here:

image

@github-actions github-actions bot added the ui label May 11, 2024
@OfekShilon OfekShilon requested a review from RubenRBS May 11, 2024 15:38
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

&.analysis,
&.mixed {
background: #fdfd96 !important;
.stack-usage {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random thought: Should we give this some ofther font?
Maybe so it looks like a codelens text? https://microsoft.github.io/monaco-editor/playground.html?source=v0.48.0#example-extending-language-services-codelens-provider-example

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! Does this look better?
image

For opt-remarks I would be interested in making part of some comments text link to source, and I'm not sure if that is possible with InjectedText. Does codeLensProvider enable this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh I prefer the font there? But also I'm cool with merging this and improving/tweaking later :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattgodbolt sorry, I don't understand: which font do you prefer?

Copy link
Member

@mattgodbolt mattgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you Ofek!

@OfekShilon OfekShilon merged commit 2687f6a into compiler-explorer:main May 14, 2024
7 checks passed
@OfekShilon OfekShilon deleted the StackUsage branch May 15, 2024 14:12
Copy link

sentry-io bot commented May 19, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'replace') forEach(panes/stack-usage-view) View Issue

Did you find this useful? React with a 👍 or 👎

@partouf
Copy link
Contributor

partouf commented May 19, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'replace') forEach(panes/stack-usage-view) View Issue

Did you find this useful? React with a 👍 or 👎

Never seen this kind of sentry comment, very interesting.

I think if we did || 'None' here

suClass: rem.Qualifier,
the problem would be fixed

@partouf
Copy link
Contributor

partouf commented May 19, 2024

Perhaps also add ? here

Qualifier: 'static' | 'dynamic' | 'dynamic,bounded';

@OfekShilon
Copy link
Member Author

OfekShilon commented May 19, 2024

Just pushed 930ee1d , in hope of learning more before applying a permanent solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants