New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make stack-usage
display inline, same as opt-view
#6469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great :)
&.analysis, | ||
&.mixed { | ||
background: #fdfd96 !important; | ||
.stack-usage { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random thought: Should we give this some ofther font?
Maybe so it looks like a codelens text? https://microsoft.github.io/monaco-editor/playground.html?source=v0.48.0#example-extending-language-services-codelens-provider-example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh I prefer the font there? But also I'm cool with merging this and improving/tweaking later :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattgodbolt sorry, I don't understand: which font do you prefer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thank you Ofek!
…rer#6469) Following the intention declaration [here](compiler-explorer#6393 (comment)): ![image](https://github.com/compiler-explorer/compiler-explorer/assets/73080/4c239691-07ac-4ab3-9745-43cf67dd5679)
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Never seen this kind of sentry comment, very interesting. I think if we did
|
Perhaps also add
|
Just pushed 930ee1d , in hope of learning more before applying a permanent solution |
Following the intention declaration here: