Detect local label assignments as directives on MIPS (#6392) #6467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For obscure reasons (see comment here) GCC MIPS inserts DWARF debug labels with the format
$LXX = .
instead of$LXX:
. So this updates the regexes in that scenario using the existing MIPS detection, to explicitly consider that specific pattern as a directive instead of an assignment. That way they are filtered correctly in the assembly output with the "Directives" option like on all other architectures.This shouldn't need any additional tests, just updating the existing ones to say those labels should now be filtered. Currently it causes test failures though, I couldn't find any testing docs or if there is an automatic way to regenerate the test files? If there is a recommended way, I can update them.