Cmake updates attempt 2 #6452
Open
Cmake updates attempt 2 #6452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add CMake 3.29 build.
|
See compiler-explorer/infra#1295 for infra updates. |
|
I see no message in CI about what the failure might be :/ . |
mathstuf
force-pushed
the
cmake-updates-attempt-2
branch
from
51c4e43
to
af6c82d
Compare
|
Thanks; fixed. |
mattgodbolt
reviewed
May 14, 2024
mattgodbolt
reviewed
May 18, 2024
There was a problem hiding this comment.
Why the duplicated semvers?
I don't see a cmake-importstd executable after installing. I see:
May/18 22:25 admin-node~/infra (main|✔) 10.0s $ ls -dl /opt/compiler-explorer/cmake*
lrwxrwxrwx 1 root root 13 Dec 10 19:54 /opt/compiler-explorer/cmake -> cmake-v3.28.0
drwxr-xr-x 6 root root 6144 May 24 2022 /opt/compiler-explorer/cmake-v3.18.2
drwxr-xr-x 6 root root 6144 May 24 2022 /opt/compiler-explorer/cmake-v3.23.1
drwxr-xr-x 6 root root 6144 Nov 20 2022 /opt/compiler-explorer/cmake-v3.24.3
drwxr-xr-x 6 root root 6144 Jan 11 2023 /opt/compiler-explorer/cmake-v3.25.1
drwxr-xr-x 6 root root 6144 Mar 28 2023 /opt/compiler-explorer/cmake-v3.26.1
drwxr-xr-x 6 root root 6144 Apr 30 04:16 /opt/compiler-explorer/cmake-v3.26.4
drwxr-xr-x 6 root root 6144 Dec 5 03:20 /opt/compiler-explorer/cmake-v3.27.9
drwxr-xr-x 6 root root 6144 Dec 10 19:53 /opt/compiler-explorer/cmake-v3.28.0
drwxr-xr-x 6 root root 6144 Dec 5 03:23 /opt/compiler-explorer/cmake-v3.28.0-rc5
drwxr-xr-x 6 root root 6144 Apr 30 04:20 /opt/compiler-explorer/cmake-v3.28.4
drwxr-xr-x 6 root root 6144 Apr 30 04:24 /opt/compiler-explorer/cmake-v3.29.2
drwxr-xr-x 6 root root 6144 May 17 04:18 /opt/compiler-explorer/cmake-v3.29.20240506-g1ea8fa8
| compiler.cmake-3_26_4.semver=3.26.4 | ||
|
|
||
| compiler.cmake-3_26.exe=/opt/compiler-explorer/cmake-v3.26/bin/cmake | ||
| compiler.cmake-3_26.semver=3.26.4 |
There was a problem hiding this comment.
this is the same semver as above. It should be unique
There was a problem hiding this comment.
Ah. The idea was to give the option of using "the latest CMake 3.x" option. I'll remove them here.
mathstuf
force-pushed
the
cmake-updates-attempt-2
branch
from
af6c82d
to
98673c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapplication of #6368.