Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mlir-translate #6421

Merged
merged 2 commits into from May 14, 2024
Merged

Conversation

harishch4
Copy link
Contributor

No description provided.

Copy link
Member

@junlarsen junlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, do you think it'd make sense to add mlir-translate for 17.0.1 and 18.1.0 as well?

Also, is there any significant difference between this and #6355?

@harishch4
Copy link
Contributor Author

Nice, do you think it'd make sense to add mlir-translate for 17.0.1 and 18.1.0 as well?

If those versions are already installed, it does make sense. However, since "trunk" is being added, this should be fine, I guess.

Also, is there any significant difference between this and #6355?

I wasn't aware that there's already a patch available. It looks almost similar to mine, but it's failing CI for some reason.

Copy link
Member

@mattgodbolt mattgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: thank you

@mattgodbolt mattgodbolt merged commit 65a3dbc into compiler-explorer:main May 14, 2024
11 checks passed
@mattgodbolt
Copy link
Member

This is rolling out now

OfekShilon pushed a commit to OfekShilon/compiler-explorer that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants