New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local/Remote Execution environment #6413
base: main
Are you sure you want to change the base?
Conversation
Took more refactoring then I had hoped, but I'm happy with the end-result |
How I tested this:
|
Maybe make it a configuration option (default off, naturally). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remarkably little change to get this I see (mostly code motion), nice work. Discussing more in person.
@@ -277,6 +285,29 @@ export class ApiHandler { | |||
} | |||
} | |||
|
|||
async handleLocalExecution(req: express.Request, res: express.Response, next: express.NextFunction) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to understand "local execution" is what in this instance? Is this local as in "on the local server itself" - the thing you said you'd comment out? I can see if being useful for testing, so another +1 on keep-it-behind-an-option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Execute on this instance yes, definitely just for testing. And I can see an option being useful, but I don't want users to accidentally turn it on, as nothing in this function is sanitized...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, but we have plenty of options that are "buyer beware" for debug etc. I think having it in an option makes sense, else how might we test it?
import {ExecutionParams} from '../../types/compilation/compilation.interfaces.js'; | ||
import {BasicExecutionResult, ExecutableExecutionOptions} from '../../types/execution/execution.interfaces.js'; | ||
|
||
export interface IExecutionEnvironment { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Breaks Heaptrack Graph in Cmake + Execution https://godbolt.org/staging/z/zz6M7TWqx |
F# execution broken https://godbolt.org/staging/z/W3nazK8oc |
First working version
This is part 1 of many for #6379
Changed in this PR:
This so that later:
Will comment out the API Endpoint before merging of course