Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #5619: Add label "Congratulations, all pictures in this album have been either uploaded or marked as not for upload #5696

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Thejas775
Copy link

Description (required)

Fixes #5619

What changes did you make and why?
Added label "Congratulations, all pictures in this album have been either uploaded or marked as not for upload" whenever user switches off the selectorSwitch.

@Thejas775 Thejas775 changed the title Fixed Issue #5619: Add label "Congratulations, all pictures in this album have been either uploaded or marked as not for upload Fixes Issue #5619: Add label "Congratulations, all pictures in this album have been either uploaded or marked as not for upload Apr 18, 2024
@nicolas-raoul
Copy link
Member

@Thejas775
Copy link
Author

Thejas775 commented Apr 20, 2024

Sir is this issue resolved by this PR ?

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why the text is not displayed here? Thanks! 🙂

1000044741.mp4

@Thejas775
Copy link
Author

Any idea why the text is not displayed here? Thanks! 🙂

1000044741.mp4

Will check on it sir !

@Thejas775
Copy link
Author

Thejas775 commented May 2, 2024

@nicolas-raoul
Screenshot from 2024-05-02 19-53-42
SIr earlier I thought the images.notempty will do the work. But now it seems the images are of total device and the filetered images is of the the particular folder. I tried using the
notForUploadStatusDao.getNotForUploadFromImageSHA1(image.id.toString()) == null
But it didnt work. If you could point me to where from can i get the status of images which are marked as not for upload or maked as upload it would be helpful.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add label "Congratulations, all pictures in this album have been either uploaded or marked as not for upload."
2 participants